1 From d68fc6ecc88a0e4532754b1a9f209881a248f4ee Mon Sep 17 00:00:00 2001
2 From: Giuseppe D'Angelo <giuseppe.dangelo@kdab.com>
3 Date: Wed, 4 Feb 2026 12:33:08 +0100
4 Subject: [PATCH] QByteArrayView: include qchar.h
5 6 QByteArrayView needs the complete definition of QChar in order to
7 define its relational operators against it.
8 9 In particular, the expansion of the
10 11 Q_DECLARE_STRONGLY_ORDERED(QByteArrayView, QChar, QT_ASCII_CAST_WARN)
12 13 macro creates an overload set where the QByteArrayView(Container)
14 constructor is considered. GCC complains that that constructor is
15 excluded via SFINAE for Container = QChar, not because QChar isn't a
16 suitable container (indeed, it's not), but because it's *incomplete* at
17 that point. When QChar is later completed, GCC is afraid that the
18 previous substitution failure might have yielded a different result,
19 and warns about it. Fix this by including QChar.
20 21 Task-number: QTBUG-143470
22 Change-Id: I705f91ef1133b59363df0cd6dbab91a5854e248c
23 Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
24 Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
25 ---
26 src/corelib/text/qbytearrayview.h | 1 +
27 1 file changed, 1 insertion(+)
28 29 diff --git a/qtbase/src/corelib/text/qbytearrayview.h b/qtbase/src/corelib/text/qbytearrayview.h
30 index 7d3e82e72a02..b19f6fd5424e 100644
31 --- a/qtbase/src/corelib/text/qbytearrayview.h
32 +++ b/qtbase/src/corelib/text/qbytearrayview.h
33 @@ -4,6 +4,7 @@
34 #define QBYTEARRAYVIEW_H
35 36 #include <QtCore/qbytearrayalgorithms.h>
37 +#include <QtCore/qchar.h>
38 #include <QtCore/qcompare.h>
39 #include <QtCore/qcontainerfwd.h>
40 #include <QtCore/qstringfwd.h>
41