diff --git a/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/gecko/GeckoProvider.kt b/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/gecko/GeckoProvider.kt index 12df28433480..d8e15ea79415 100644 --- a/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/gecko/GeckoProvider.kt +++ b/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/gecko/GeckoProvider.kt @@ -7,7 +7,6 @@ package org.mozilla.fenix.gecko import android.content.Context import androidx.annotation.VisibleForTesting import mozilla.components.browser.engine.gecko.autofill.GeckoAutocompleteStorageDelegate -import mozilla.components.browser.engine.gecko.crash.GeckoCrashPullDelegate import mozilla.components.browser.engine.gecko.ext.toContentBlockingSetting import mozilla.components.concept.engine.EngineSession.TrackingProtectionPolicy import mozilla.components.concept.storage.CreditCardsAddressesStorage @@ -72,6 +71,7 @@ object GeckoProvider { ), ) + /* geckoRuntime.crashPullDelegate = GeckoCrashPullDelegate( dispatcher = { crashIDs -> context.components.appStore.dispatch( @@ -79,6 +79,7 @@ object GeckoProvider { ) }, ) + */ return geckoRuntime } @@ -122,7 +123,6 @@ object GeckoProvider { .extensionsProcessEnabled(true) .extensionsWebAPIEnabled(true) .translationsOfferPopup(context.settings().offerTranslation) - .crashPullNeverShowAgain(context.settings().crashPullNeverShowAgain) .setSameDocumentNavigationOverridesLoadType( FxNimbus.features.sameDocumentNavigationOverridesLoadType.value().enabled, ) diff --git a/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/settings/SecretSettingsFragment.kt b/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/settings/SecretSettingsFragment.kt index 3c071edf51a4..a16994ac9a1a 100644 --- a/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/settings/SecretSettingsFragment.kt +++ b/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/settings/SecretSettingsFragment.kt @@ -314,7 +314,7 @@ class SecretSettingsFragment : PreferenceFragmentCompat() { } requirePreference(R.string.pref_key_crash_pull_never_show_again).apply { - isVisible = true + isVisible = false isChecked = context.settings().crashPullNeverShowAgain onPreferenceChangeListener = SharedPreferenceUpdater() } diff --git a/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/utils/Settings.kt b/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/utils/Settings.kt index 35d4c5a9c0a4..0e8ff24bd1cd 100644 --- a/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/utils/Settings.kt +++ b/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/utils/Settings.kt @@ -536,10 +536,7 @@ class Settings(private val appContext: Context) : PreferencesHolder { true, ) - var crashReportChoice by stringPreference( - appContext.getPreferenceKey(R.string.pref_key_crash_reporting_choice), - default = CrashReportOption.Ask.toString(), - ) + var crashReportChoice = CrashReportOption.Never.toString() val isRemoteDebuggingEnabled by booleanPreference( appContext.getPreferenceKey(R.string.pref_key_remote_debugging), @@ -905,10 +902,7 @@ class Settings(private val appContext: Context) : PreferencesHolder { * Indicates if the user denies to ever see again the Remote Settings crash * pull UI. */ - var crashPullNeverShowAgain: Boolean by booleanPreference( - appContext.getPreferenceKey(R.string.pref_key_crash_pull_never_show_again), - default = false, - ) + var crashPullNeverShowAgain: Boolean = true @VisibleForTesting internal fun timeNowInMillis(): Long = System.currentTimeMillis()