package sa4021 import ( "go/ast" "honnef.co/go/tools/analysis/code" "honnef.co/go/tools/analysis/facts/generated" "honnef.co/go/tools/analysis/lint" "honnef.co/go/tools/analysis/report" "honnef.co/go/tools/pattern" "golang.org/x/tools/go/analysis" "golang.org/x/tools/go/analysis/passes/inspect" ) var SCAnalyzer = lint.InitializeAnalyzer(&lint.Analyzer{ Analyzer: &analysis.Analyzer{ Name: "SA4021", Run: run, Requires: []*analysis.Analyzer{inspect.Analyzer, generated.Analyzer}, }, Doc: &lint.RawDocumentation{ Title: `\"x = append(y)\" is equivalent to \"x = y\"`, Since: "2019.2", Severity: lint.SeverityWarning, MergeIf: lint.MergeIfAny, }, }) var Analyzer = SCAnalyzer.Analyzer var checkSingleArgAppendQ = pattern.MustParse(`(CallExpr (Builtin "append") [_])`) func run(pass *analysis.Pass) (interface{}, error) { fn := func(node ast.Node) { _, ok := code.Match(pass, checkSingleArgAppendQ, node) if !ok { return } report.Report(pass, node, "x = append(y) is equivalent to x = y", report.FilterGenerated()) } code.Preorder(pass, fn, (*ast.CallExpr)(nil)) return nil, nil }